Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Buffers type #193

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Remove Buffers type #193

merged 4 commits into from
Dec 19, 2023

Conversation

rmja
Copy link
Contributor

@rmja rmja commented Dec 11, 2023

cc @dragonnn @MathiasKoch

If this gets merged, then #189, when aligned, can follow.

MathiasKoch
MathiasKoch approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍

@MathiasKoch
Copy link
Member

@rmja Could you fix the CI?

@rmja
Copy link
Contributor Author

rmja commented Dec 19, 2023

Sorry for the delay, I think it is ready now.

@MathiasKoch MathiasKoch merged commit 94eb974 into FactbirdHQ:master Dec 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasKoch MathiasKoch MathiasKoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmja @MathiasKoch